Introduce Apache Arrow-based ingestion protocol #4834
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted zero visual differences across 370 screens tested: view results. Expected differences? Click here. Last updated for commit 8bed747. This comment will update as new commits are pushed. |
metalmatze
reviewed
Jul 1, 2024
| message WriteResponse { | ||
| // When record is non-empty it contains the bytes of an arrow record that | ||
| // contains a column containing the stacktraces that are unknown. | ||
| bytes record = 1; |
Member
There was a problem hiding this comment.
It would be nice to make the returning record's schema part of the protocol, at least adding a comment on what to expect roughly.
Member
Author
There was a problem hiding this comment.
The record has metadata and the protocol expects the parca_write_schema_version to be set to the version, which determines the schema. See the constants in pkg/normalizer/arrow.go.
metalmatze
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The protocol works by
This reduces the amount of work that has to be done to ingest data, and reduces the amount of data that needs to be transferred by a client. For a start this implements no caching, that part is left for future work, but the protocol already supports it, at present the server will just always ask the client for the full stacktrace information.