fix(snap): store profiles in SNAP_COMMON by default #4797
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until this commit, the default storage location for profiles on disk was in `$SNAP_DATA/profiles`, but as highlighted in both #4708 and in https://snapcraft.io/docs/data-locations, the `$SNAP_DATA` directory is versioned per-revision of the snap, whereas `$SNAP_COMMON` persists across revisions. This change leaves config in the same location in `$SNAP_DATA`, because versioning config files with revisions might still be desirable. Existing installs should not be affected, as the default is set on first run. Fixes #4708
|
✅ Meticulous spotted zero visual differences across 656 screens tested: view results. Expected differences? Click here. Last updated for commit 3f55898. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until this commit, the default storage location for profiles on disk was in
$SNAP_DATA/profiles, but as highlighted in both #4708 and in https://snapcraft.io/docs/data-locations, the$SNAP_DATAdirectory is versioned per-revision of the snap, whereas$SNAP_COMMONpersists across revisions.This change leaves config in the same location in
$SNAP_DATA, because versioning config files with revisions might still be desirable.Existing installs should not be affected, as the default is set on first run.
Fixes #4708