pkg/parcacol: Correctly handle delta non cpu/ns profiles #4592
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 1 of 416 screens tested: view and approve differences detected. Last updated for commit ff4ed0e. This comment will update as new commits are pushed. |
brancz
reviewed
May 7, 2024
| } | ||
|
|
||
| queryParts.Meta.Timestamp = start | ||
| queryParts.Meta.SampleType = resultType |
Member
There was a problem hiding this comment.
I'm not a fan of overriding a sub-struct of queryParts like this, we don't use anything else of queryParts
Member
Author
There was a problem hiding this comment.
We return queryParts because those are now passed into SymbolizeArrowRecord to check for delta profiles.
Since it's possible to have delta profiles that aren't cpu/nanoseconds we still need to query them correctly. Additionally, setting the resultType is fixed again too.
1f3eccc to
ff4ed0e
Compare
brancz
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since it's possible to have delta profiles that aren't cpu/nanoseconds we still need to query them correctly.
Additionally, setting the resultType is fixed again too.