Improve filter profile data #4313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Meticulous spotted zero visual differences across 379 screens tested: view results. Last updated for commit 9296146. This comment will update as new commits are pushed. |
8511bc9 to
f623f29
Compare
f623f29 to
20517a8
Compare
Contributor
Author
|
Updating it to slice the records instead of marking full rows as null It's slightly worse, but removes some of the footguns from just marking whole rows as null |
Previously we were rebuilding the record when we performed a filtering operation. This caused a lot of copying of data. Instead we now just mark the filtered our values as null in the array bitmap.
name old time/op new time/op delta FilterData-10 5.00ms ± 2% 0.38ms ± 1% -92.37% (p=0.000 n=10+10) name old alloc/op new alloc/op delta FilterData-10 6.28MB ± 0% 0.00MB ± 1% -99.94% (p=0.000 n=10+10) name old allocs/op new allocs/op delta FilterData-10 3.91k ± 1% 0.07k ± 2% -98.19% (p=0.000 n=10+10)
This prevents us from having to skip over records later and other footguns where we Sum which accesses the data directly and ignores nulls
20517a8 to
7ae0838
Compare
afab681 to
d56d156
Compare
d56d156 to
9296146
Compare
metalmatze
approved these changes
Feb 26, 2024
Member
metalmatze
left a comment
There was a problem hiding this comment.
Very nice!
Improving ergonomics seems the right way forward. Overall this performance so much better, so I'm fine paying that small price. 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark fields as null instead of rebuilding record during filtering.
thor@thors-MacBook-Pro ~/.../parca/pkg/query % benchstat before.txt after.txt name old time/op new time/op delta FilterData-10 5.00ms ± 2% 0.38ms ± 1% -92.37% (p=0.000 n=10+10) name old alloc/op new alloc/op delta FilterData-10 6.28MB ± 0% 0.00MB ± 1% -99.94% (p=0.000 n=10+10) name old allocs/op new allocs/op delta FilterData-10 3.91k ± 1% 0.07k ± 2% -98.19% (p=0.000 n=10+10)