Encode query params when navigation is triggered in useURLState #4288
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Meticulous spotted visual differences in 10 of 369 screens tested: view and approve differences detected. Last updated for commit 6a7a673. This comment will update as new commits are pushed. |
… into special-characters
yomete
commented
Jan 15, 2024
| <div | ||
| className={cx( | ||
| '!absolute inset-y-[1px] right-[1px] rounded-bl-none rounded-tl-none rounded-md w-8 z-10' | ||
| '!absolute inset-y-[1px] right-[1px] rounded-bl-none rounded-tl-none rounded-md w-8 z-4' |
Contributor
Author
There was a problem hiding this comment.
This fixes a visual bug where the filter by function action button is superimposed on top of the metrics graph tooltip.
brancz
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently have a bug where special characters get lost (replaced by an empty space) in the query browser, only after using the
GroupandSortactions. See #4158.This is happening because (when a navigation is triggered using the
useURLStatehook) the query expression param is not being encoded before being sent back to the URL. This PR fixes that and also for additional cases that were not listed in the original issue i.e. when comparing two profiles and closing one of the compared profiles.How to reproduce:
Add the following to your
parca.yamlfile to add the label valueUsing the query browser, query for the label value above (querier.+) and then try to sort or group, and you should get the error below, and notice in the query browser that the plus sign has been replaced by an empty space.
Resolves #4158