Use checked allocator #3673
Merged
Use checked allocator #3673
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will help us discover leaks in the allocator
2b5f8ca to
ea71e1f
Compare
|
🤖 Meticulous spotted visual differences in 3 of 269 screens tested: view and approve differences detected. Last updated for commit d5e7f80. This comment will update as new commits are pushed. |
metalmatze
approved these changes
Aug 24, 2023
Member
metalmatze
left a comment
There was a problem hiding this comment.
Nice, definitely needed! 💯
defer mem.AssertSize(t, 0) is pretty cool.
brancz
approved these changes
Aug 24, 2023
Member
|
Can we rename |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses a checked allocator throughout unit tests.
This exposed some allocation leaks that were fixed as well.