pkg/query/flamegraph_arrow: Properly calculate height #3632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I've also updated Go to 1.21 to use the new |
|
✅ Meticulous spotted zero visual differences across 211 screens tested: view results. Last updated for commit 8d114c8. This comment will update as new commits are pushed. |
brancz
approved these changes
Aug 16, 2023
7cb23d7 to
98d51c6
Compare
98d51c6 to
6d0e36d
Compare
Previously the height was estimated, but didn't take inlined functions and injected label nodes into account.
6d0e36d to
8d114c8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the height was estimated, but didn't take inlined functions and injected label nodes into account.