pkg/query/flamegraph_arrow: Cast bytes to string when accessing maps keys #3597
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…keys Additionally, there was the assumption that the MarshalStringMap is sorted which broke the key access to the rootsRow map. Therefore, for the specific case a MarshalStringMapSorted was added (again).
|
✅ Meticulous spotted zero visual differences across 239 screens tested: view results. Last updated for commit f987c22. This comment will update as new commits are pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additionally, there was the assumption that the MarshalStringMap is sorted which broke the key access to the rootsRow map. Therefore, for the specific case a MarshalStringMapSorted was added (again).