Skip to content

Conversation

@manojVivek
Copy link
Contributor

@manojVivek manojVivek commented Aug 9, 2023

  • Fixed the babel warning
  • Revert the recent eslint package upgrade

@metalmatze
Copy link
Member

Why do we need to revert eslint? Do the plugins not yet work with that newer version?
How can we make sure renovate doesn't instantly overwrite this revert?

@manojVivek
Copy link
Contributor Author

Why do we need to revert eslint? Do the plugins not yet work with that newer version?

It looks like the newer version of the ESLint and the react-scripts are incompatible. react-scripts is right now in an unmaintained state, last released a year ago, should be the reason for this.

How can we make sure renovate doesn't instantly overwrite this revert?

This works in my local, just waiting to see if this passes in the CI so that I can add the necessary renovatebot config to prevent upgrading this package.

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 9, 2023

🤖 Meticulous replayed 50 user sessions and took 252 screenshots. Meticulous has not yet run on 00faf45 of the main branch and so there was nothing to compare against.

If you recently setup Meticulous, this is expected. Meticulous will start reporting comparisons for new pull requests after the next commit to the main branch.

Last updated for commit c88ceea. This comment will update as new commits are pushed.

@metalmatze
Copy link
Member

Ok, great! The JS/TS parts are passing. I'll merge this ignoring the running but unrelated CI checks.

@metalmatze metalmatze merged commit 77528a2 into main Aug 9, 2023
@metalmatze metalmatze deleted the build-fix branch August 9, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants