feat(snap): add config options to send profiles to a remote store #3572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
While testing this I noticed that we were still using the deprecated |
brancz
approved these changes
Aug 8, 2023
Contributor
Author
|
@brancz can we get this merged so I can build this into the charm & relations? :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a config option to the Parca snap to simplify the onboarding to Parca Cloud.
This change introduces a new snap config option named remote-store-bearer-token, and sets the default store address to grpc.polarsignals.com:443.
When a token is set, any other config about storage persistence or memory is ignored, and Parca's mode is set to
scraper-only.