Skip to content

Conversation

@monicawoj
Copy link
Contributor

@monicawoj monicawoj commented Aug 3, 2023

This PR implements design changes to the header, layout, and Parca profiler as can be seen in the new design here: https://www.figma.com/file/sMMnQwWpPovvn5JM3vhwL7/Parca?type=design&node-id=166-97938&mode=design&t=cSoqzmTIHi22lYgu-0

Other notable changes:

  • visualization panel top bar layout to better align the buttons between panels when "Sort" and "Group" are not shown
  • co-locating Parca profile view preferences with the profile view section (instead of in the top navbar)
  • adding grid lines to the Profile Metrics Graph (see below)

Note: This PR does not include the new horizontal tooltip shown in the design. That will be done in a separate PR.

Screenshot 2023-08-25 at 15 45 39 Screenshot 2023-08-25 at 15 45 29

@alwaysmeticulous
Copy link

alwaysmeticulous bot commented Aug 3, 2023

🤖 Meticulous spotted visual differences in 229 of 312 screens tested: view and approve differences detected.

Last updated for commit ec839ce. This comment will update as new commits are pushed.

@manojVivek
Copy link
Contributor

Good to see that Meticulous has spotted these changes!

@monicawoj monicawoj marked this pull request as ready for review August 24, 2023 14:22
@monicawoj monicawoj requested a review from a team as a code owner August 24, 2023 14:22
Copy link
Contributor

@yomete yomete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@monicawoj monicawoj merged commit 7456e3b into main Aug 25, 2023
@monicawoj monicawoj deleted the design-changes branch August 25, 2023 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants