Add SortBy and GroupBy actions for Icicle Graphs #3479
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want to add sorting to the icicle graph itself. This allows to not only sort by function name (the default and what's currently supported) but also sort by cumulative values (such that the highest functions are always left) and in compare mode by diff value (meaning the functions that got worse are left and better right). This can make finding specific things even easier.
|
🤖 Meticulous spotted visual differences in 210 of 229 screens tested: view and approve differences detected. Last updated for commit 4be0494. This comment will update as new commits are pushed. |
manojVivek
approved these changes
Jul 20, 2023
Contributor
manojVivek
left a comment
There was a problem hiding this comment.
Great looking UI! 👏🏼
Just a couple of minor nits and the linter comments, otherwise looks good from the UI perspective.
metalmatze
commented
Jul 20, 2023
Member
Author
|
Thanks a lot for fixing those re-renders @manojVivek 👏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two additional UI components to the arrow icicle graph.
One is a SortBy dropdown to either sort by the function name (the default and what we currently only had) or cumulative value.
The other component is a dropdown that toggles GroupBy function name or pprof labels or no grouping at all.
All state is stored in the URL. Sharing a profile keeps the group by and sort by order.
Group By
No grouping
Function name (the default)
(pprof) Labels
Function and Labels
Sorting
Function name (the default)
This sorts alphabetically by function names:
Cumulative value
This sorts by cumulative value in descending order. This makes the biggest values show up to the left and the smallest to the right:
