pkg/query: Support unsymbolized profiles with arrow fg #3433
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brancz
approved these changes
Jul 11, 2023
Member
brancz
left a comment
There was a problem hiding this comment.
lgtm but pleeeeeeease let's refactor those continue statements
Member
Author
|
Yep, I'm sure they are going sooner than later too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support adding rows with just addresses, we'd have had to copy a lot of code. This was the perfect opportunity to finally introduce a better abstract - the
flamegraphBuilder.There are some other pieces we may consider moving into this struct/builder in the future. I can also see having something like a
flamegraphBuilder.NewRecord()to wrap some of the internals even more. Overall, these are minor improvements though.The UI needed some small tweaks to properly support function names being
null.