Feature/add rgba array support #3124
Conversation
| var rgbData = this.__addimage__.arrayBufferToBinaryString(rgbOut); | ||
| var alphaData = this.__addimage__.arrayBufferToBinaryString(alphaOut); |
There was a problem hiding this comment.
I assumed these accepted ArrayBuffer, not Uint8Array given the name...
There was a problem hiding this comment.
I did not give enough thought to these before but the other code paths call it the same way.
If it is a buffer, make it an array, if it is an array, run it through arrayBufferToBinaryString.
https://github.com/MrRio/jsPDF/blob/master/src/modules/jpeg_support.js#L71-L83
All usage should be checked and name changed if that is uniform across all usage.
There was a problem hiding this comment.
Naming of the arrayBufferToBinaryString should imo be changed on a separate PR.
HackbrettXXX
left a comment
There was a problem hiding this comment.
Thanks for this PR :)
| it("with alpha", () => { | ||
| const c = document.createElement("canvas"); | ||
| const ctx = c.getContext("2d"); | ||
| ctx.fillStyle = "#FFFFFF"; | ||
| ctx.fillRect(0, 0, 150, 60); | ||
| ctx.fillStyle = "#AA00FF77"; | ||
| ctx.fillRect(10, 10, 130, 40); | ||
| const dataFromCanvas = ctx.getImageData(0, 0, 150, 60); | ||
|
|
||
| const doc = new jsPDF({ | ||
| orientation: "p", | ||
| unit: "px", | ||
| format: "a4", | ||
| floatPrecision: 2 | ||
| }); | ||
| doc.addImage(dataFromCanvas, 10, 10, 150, 60); | ||
|
|
||
| comparePdf(doc.output(), "rgba_alpha.pdf", "addimage"); | ||
| }); |
There was a problem hiding this comment.
Seems like this test case produces slightly different results in IE. Could you investigate why?
There was a problem hiding this comment.
As it would take some time to setup a windows test environment myself, I'm going throw a question: is IE11 really something that needs to be supported still? Microsoft itself tries to migrate everyone to Edge as fast as possible with all the IE problems and security issues being abundant.
There was a problem hiding this comment.
You're right. IE is probably not that important anymore. I think it's OK, if we drop IE support for new features. So let's just skip this test case in IE.
# Conflicts: # types/jspdf-tests.ts
|
👍 |
This PR adds support for RGBA buffer input. This is the format that is output by DOM canvas
getImageDatabut could be generated elsewhere.