Skip to content

Implement V3/V4#128

Merged
paragonie-security merged 30 commits into
masterfrom
new-versions-implementation
Jul 30, 2021
Merged

Implement V3/V4#128
paragonie-security merged 30 commits into
masterfrom
new-versions-implementation

Conversation

@paragonie-security

@paragonie-security paragonie-security commented Jul 18, 2021 •
edited
Loading

Copy link
Copy Markdown
Contributor

See #127. This does not have test vectors yet. This is a PR against the spec branch to make the changes easier to visualize on Github.

The next steps are as follows (just to prevent any astonishment):

  1. Minimum two week comment period for Initial Draft for PASETO v3/v4 specifications #127, starting on 2021-07-19 and concluding 2021-08-02. We will be reaching out to PASETO maintainers to ask them for feedback, but the floor's open to anyone.
  2. Once we're happy with v3/v4's design and merge Initial Draft for PASETO v3/v4 specifications #127, this branch will be updated to conform to the spec (assuming it changes).
  3. This pull request will be re-targeted at the master branch.
  4. Once we're happy with the implementation, the branch will be merged.
  5. We will then release a new major version of the PASETO library for PHP with the new features.
    • The main reason it's a breaking change is that phpecc relies on ext-gmp and we raised our minimum PHP version.
    • (After it's is released, we may bump the minimum PHP version to 7.4 or 8.0 in another minor release. We just want to minimize the number of people orphaned on v1/v2 protocols.)
  6. The matrix on https://paseto.io will be updated.

@paragonie-security paragonie-security mentioned this pull request Jul 18, 2021
Merged
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch 3 times, most recently from 478f544 to e463ef2 Compare July 21, 2021 10:28
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch 2 times, most recently from 94b744f to 8de2e9e Compare July 21, 2021 19:23
@paragonie-security paragonie-security mentioned this pull request Jul 21, 2021
Merged
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch from 03feabf to 8747436 Compare July 22, 2021 15:48
@panva

panva commented Jul 22, 2021

Copy link
Copy Markdown
Contributor

panva/paseto#19 (comment)

@paragonie-security

paragonie-security commented Jul 28, 2021

Copy link
Copy Markdown
Contributor Author

There is now a PHP implementation of PASERK that builds upon the implementation in this branch.

This was referenced Jul 28, 2021
Closed
Closed
Closed
Closed
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch from fc617f9 to 4db1660 Compare July 28, 2021 01:49
@paragonie-security paragonie-security mentioned this pull request Jul 28, 2021
Closed
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch 8 times, most recently from e7934ba to e5e8084 Compare July 29, 2021 19:46
@paragonie-security
Implement V3/V4 in PHP
01519aa
@paragonie-security
Create test vectors
c080bd5 
These are subject to change pending on the discussion in #280.

The final test vectors for v3/v4 will be published on https://github.com/paseto-standard
@paragonie-security
Nits
d50a3a4
@paragonie-security
Add JSON test vector file for v4
d1e36fb
@paragonie-security
Add nonce, secret keys
74ca013 
(and pem-encoded keys to v3.local vectors)
@paragonie-security
Add pem-encoded keys to v2/v4
eeab0a7
@paragonie-security
Correct private key PEM encoding.
c04e29d 
panva/paseto#19 (comment)
@paragonie-security
Boyscouting
0b89fab
@paragonie-security
Normalize PEM-encoded line endings
91f0ad1
@paragonie-security
Normalize public keys too
75527da
@paragonie-security
Return static, not self
06a8f93
@paragonie-security
Add methods to ProtocolCollection
2bdf648
@paragonie-security
Remove reference to sodium_compat internal class
9708d6d 
See #111 for background
@paragonie-security
Remove duplicate docblocks
6229c14 
See #105
@paragonie-security
Add parser rules to abbreviated example
c474fb2 
Fixes #106
@paragonie-security
Improve implicit assertion UX
79c4a3e
@paragonie-security
Add var_dump to v3 test code
bfb9cd7
@paragonie-security
Attempt to fix intermittent issue
4d56114
@paragonie-security
Add test vectors with arbitrary, non-JSON footers
ff797e5
@paragonie-security
Use given nonce in new test vectors.
314f28c 
Thanks @panva!
@paragonie-security
Fix v2/v4 test vectors, add test coverage
0f16d97
@paragonie-security
Add Footer JSON validation rules.
4ee1139
@paragonie-security
Reject excessive depths without needing to parse token
ca2d05e
@paragonie-security
Throw if invalid JSON is detected in depth check
b03b3fb
@paragonie-security
Strip whitespace too
f175aa6
@paragonie-security
Reorganize code, allow Parser to restrict JSON payload too
b1de5ee
@paragonie-security
Clean up various code nits.
d7ab9ed
@paragonie-security
Update test vectors, remove stale test code
eed0073 
We now use the KnownAnswerTest class to validate the test vectors stored in JSON files.
@paragonie-security
Use 48 bytes for v3 auth keys
f15e846
@paragonie-security paragonie-security force-pushed the new-versions-implementation branch from e5e8084 to f15e846 Compare July 29, 2021 19:48
Base automatically changed from new-versions to master July 30, 2021 11:54
@paragonie-security

paragonie-security commented Jul 30, 2021

Copy link
Copy Markdown
Contributor Author

Ditto for #127 (comment)

@paragonie-security paragonie-security merged commit ce1bc44 into master Jul 30, 2021
@paragonie-security paragonie-security deleted the new-versions-implementation branch July 30, 2021 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paragonie-security @panva