chore(trie): Overlay arguments for write trie changeset methods#18732
Merged
mediocregopher merged 3 commits into18460-trie-changesetsfrom Sep 29, 2025
Merged
Conversation
This allows for passing optional overlays into the `write_trie_changesets` and `write_storage_trie_changesets` provider methods. The overlay is a TrieUpdates which is used to augment the state of the trie db tables. Using the overlay we can write changesets as if the DB is at a previous block, which will be used during pipeline sync. Implementing this change required refactoring the StorageTrieCurrentValuesIter utility to accept a TrieCursor rather than a normal DbCursor. It also required implementing a TrieCursorIter which wraps a TrieCursor into an Iterator, for passing in to `storage_trie_wiped_changeset_iter`. Using both of these changes we could use an InMemoryTrieCursor instead of a direct db cursor.
yongkangc
approved these changes
Sep 29, 2025
Contributor
yongkangc
left a comment
There was a problem hiding this comment.
lgtm, i dont have any nits and the pr makes sense to me overall
mattsse
approved these changes
Sep 29, 2025
Collaborator
mattsse
left a comment
There was a problem hiding this comment.
lgtm!
makes sense to me
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for passing optional overlays into the
write_trie_changesetsandwrite_storage_trie_changesetsprovider methods.The overlay is a TrieUpdates which is used to augment the state of the trie db tables. Using the overlay we can write changesets as if the DB is at a previous block, which will be used during pipeline sync.
Implementing this change required refactoring the
StorageTrieCurrentValuesIter utility to accept a TrieCursor rather than a normal DbCursor. It also required implementing a TrieCursorIter which wraps a TrieCursor into an Iterator, for passing in to
storage_trie_wiped_changeset_iter. Using both of these changes we could use an InMemoryTrieCursor instead of a direct db cursor.