Describe the feature
we currently do:
|
for encoded in transactions { |
|
let tx = N::SignedTx::decode_2718_exact(encoded.as_ref())?; |
|
let signer = tx.try_recover()?; |
|
let tx = WithEncoded::new(encoded, tx.with_signer(signer)); |
|
let _gas_used = builder.execute_transaction(tx)?; |
|
} |
for the entire block on every new flashblock, this is wasteful work and we can cache this in
instead.
we can either prepare this when we push
|
self.blocks.push(flashblock); |
or lazily
on push is probably more efficient because then it's already prepared
TODO
- introduce new inner flashblock container type that has
txs: WithEnoceded<Recovered<N::SignedTx> as well
- use those during execution
- if recovery fails (we don't expect this) we simply reset the entire blocks
Additional context
blocked by #18183
Describe the feature
we currently do:
reth/crates/optimism/flashblocks/src/service.rs
Lines 149 to 154 in 3ad9743
for the entire block on every new flashblock, this is wasteful work and we can cache this in
reth/crates/optimism/flashblocks/src/service.rs
Line 39 in 3ad9743
instead.
we can either prepare this when we push
reth/crates/optimism/flashblocks/src/service.rs
Line 85 in 3ad9743
or lazily
on push is probably more efficient because then it's already prepared
TODO
txs: WithEnoceded<Recovered<N::SignedTx>as wellAdditional context
blocked by #18183