-
Notifications
You must be signed in to change notification settings - Fork 2.4k
drop support for total difficulty table entirely #16586
Copy link
Copy link
Closed
Labels
A-dbRelated to the databaseRelated to the databaseC-debtA clean up/refactor of existing codeA clean up/refactor of existing codeC-enhancementNew feature or requestNew feature or requestM-prevent-stalePrevents old inactive issues/PRs from being closed due to inactivityPrevents old inactive issues/PRs from being closed due to inactivityS-needs-designThis issue requires design work to think about how it would best be accomplishedThis issue requires design work to think about how it would best be accomplished
Description
Describe the feature
we stopped using total difficulty a while ago and require that all difficulty activated hardforks (merge) are known and completed.
we currently still maintain the total difficulty table, which is effectively unused now.
so we can drop support for:
reth/crates/storage/db-api/src/tables/mod.rs
Lines 309 to 313 in 6c05d59
| /// Stores the total difficulty from a block header. | |
| table HeaderTerminalDifficulties { | |
| type Key = BlockNumber; | |
| type Value = CompactU256; | |
| } |
and all read/writes/unwinds etc.
we should entirely stop using this.
however there could be some edge cases when a user downgrades, so this changes must be done with this in mind
Additional context
No response
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
A-dbRelated to the databaseRelated to the databaseC-debtA clean up/refactor of existing codeA clean up/refactor of existing codeC-enhancementNew feature or requestNew feature or requestM-prevent-stalePrevents old inactive issues/PRs from being closed due to inactivityPrevents old inactive issues/PRs from being closed due to inactivityS-needs-designThis issue requires design work to think about how it would best be accomplishedThis issue requires design work to think about how it would best be accomplished
Type
Projects
Status
Done