Skip to content

drop support for total difficulty table entirely #16586

@mattsse

Description

@mattsse

Describe the feature

we stopped using total difficulty a while ago and require that all difficulty activated hardforks (merge) are known and completed.

we currently still maintain the total difficulty table, which is effectively unused now.
so we can drop support for:

/// Stores the total difficulty from a block header.
table HeaderTerminalDifficulties {
type Key = BlockNumber;
type Value = CompactU256;
}

and all read/writes/unwinds etc.
we should entirely stop using this.

however there could be some edge cases when a user downgrades, so this changes must be done with this in mind

Additional context

No response

Metadata

Metadata

Assignees

Labels

A-dbRelated to the databaseC-debtA clean up/refactor of existing codeC-enhancementNew feature or requestM-prevent-stalePrevents old inactive issues/PRs from being closed due to inactivityS-needs-designThis issue requires design work to think about how it would best be accomplished

Type

No type

Projects

Status

Done

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions