Describe the feature
Right now DatabaseProof has an associated TX type and takes &'a Self::TX on every method:
|
/// Extends [`Proof`] with operations specific for working with a database transaction. |
|
pub trait DatabaseProof<'a, TX> { |
|
/// Create a new [Proof] from database transaction. |
|
fn from_tx(tx: &'a TX) -> Self; |
|
|
|
/// Generates the state proof for target account based on [`TrieInput`]. |
|
fn overlay_account_proof( |
|
tx: &'a TX, |
|
input: TrieInput, |
|
address: Address, |
|
slots: &[B256], |
|
) -> Result<AccountProof, StateProofError>; |
|
|
|
/// Generates the state [`MultiProof`] for target hashed account and storage keys. |
|
fn overlay_multiproof( |
|
tx: &'a TX, |
|
input: TrieInput, |
|
targets: MultiProofTargets, |
|
) -> Result<MultiProof, StateProofError>; |
|
} |
This is not necessary, instead we can make this into a regular trait that is stateful and takes &self. For example it would look like:
/// Extends [`Proof`] with operations specific for working with a database transaction.
pub trait DatabaseProof {
/// Generates the state proof for target account based on [`TrieInput`].
fn overlay_account_proof(
&self,
input: TrieInput,
address: Address,
slots: &[B256],
) -> Result<AccountProof, StateProofError>;
/// Generates the state [`MultiProof`] for target hashed account and storage keys.
fn overlay_multiproof(
&self,
input: TrieInput,
targets: MultiProofTargets,
) -> Result<MultiProof, StateProofError>;
} And the implementers (like Proof etc) can have a from_tx method on the struct itself
Additional context
No response
Describe the feature
Right now
DatabaseProofhas an associatedTXtype and takes&'a Self::TXon every method:reth/crates/trie/db/src/proof.rs
Lines 13 to 32 in db269f3
This is not necessary, instead we can make this into a regular trait that is stateful and takes
&self. For example it would look like:And the implementers (like
Proofetc) can have afrom_txmethod on the struct itselfAdditional context
No response