Merged
Conversation
markdascher
commented
Nov 19, 2021
| include packaging/Makefile.packaging | ||
|
|
||
| .PHONY: depend clean test build tarball | ||
| .DEFAULT: build |
Contributor
Author
There was a problem hiding this comment.
This never did anything. Whoever wrote it probably meant to set build as the default target, but that isn't what .DEFAULT does. In fact, the prerequisites of .DEFAULT are ignored except when literally running make .DEFAULT from a command-line.
There's a special .DEFAULT_GOAL variable that would set the default target, but it's more common to just list the default target first.
markdascher
commented
Nov 19, 2021
| .PHONY: depend clean test build tarball | ||
| .DEFAULT: build | ||
|
|
||
| GOFLAGS="-trimpath" |
Contributor
Author
There was a problem hiding this comment.
Adding -trimpath to scrub local file paths from public release builds.
luk3thomas
approved these changes
Nov 19, 2021
baggiosw
approved these changes
Nov 19, 2021
Contributor
|
Whoa. Thanks for finally tackling this! |
This was referenced Nov 19, 2021
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
VividCortex/godaemon#28 eliminates all CGO dependencies, which means we can now cross-compile for FreeBSD. Added both x86 and x64 builds to the Makefile, and tested to make sure they run.
This means we can probably close #207. I still think that branch does some things better than godaemon, but it no longer makes enough of a difference to warrant the risks.
Here's how I updated the godaemon package: