Make various tests pass on MacOS ARM#21032
Merged
benjyw merged 1 commit intopantsbuild:mainfrom Jun 8, 2024
Merged
Conversation
benjyw
commented
Jun 8, 2024
| "algorithm": "sha256", | ||
| "hash": "c286cf298426064079ed96a9e4a9d39e7f3e9bf15ba60701e95f5492f28415c7", | ||
| "url": "https://files.pythonhosted.org/packages/21/a6/35f83efec687615c711fe0a09b67e58f6d1254db27b1013119de46f450bd/gitdb-4.0.10-py3-none-any.whl" | ||
| "hash": "81a3407ddd2ee8df444cbacea00e2d038e40150acfa3001696fe0dcf1d3adfa4", |
Contributor
Author
There was a problem hiding this comment.
Getting the flake8 integration test to pass just required a newer lockfile.
benjyw
commented
Jun 8, 2024
| args = [ | ||
| "--backend-packages=['pants.backend.python', 'pants.backend.python.providers.experimental.pyenv']", | ||
| "--source-root-patterns=['src']", | ||
| "--pyenv-python-provider-installation-extra-env-vars=['HOME']", |
Contributor
Author
There was a problem hiding this comment.
Installing Python 2.7 via pyenv requires access to brew (to get a compatible openssl), and brew only runs if HOME is set.
benjyw
commented
Jun 8, 2024
| """ | ||
| target_name = "in_folder" | ||
| versions = ["3.2.1", "3.0.0"] | ||
| versions = ["3.2.1", "3.2.2"] |
Contributor
Author
There was a problem hiding this comment.
3.0.0 is not available on MacOS ARM, so we now conflict two more recent versions in the test.
benjyw
commented
Jun 8, 2024
benjyw
commented
Jun 8, 2024
|
|
||
| def test_resolve_image_id(rule_runner: RuleRunner) -> None: | ||
| platform = Platform.create_for_localhost() | ||
| platform = Platform.create_for_localhost().for_linux() |
Contributor
Author
There was a problem hiding this comment.
Self-explanatory I hope.
df12158 to
e89ad85
Compare
huonw
approved these changes
Jun 8, 2024
Contributor
huonw
left a comment
There was a problem hiding this comment.
Thanks for working through these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't run tests on this platform in CI (and we only run a subset of
tests on any platform other than Linux x86_64).
Therefore some tests have rotted on that platform. This PR fixes them.
See #20993 for more.