Write directly to relevant notes file in changelog.py#19303
Merged
huonw merged 10 commits intopantsbuild:mainfrom Jun 14, 2023
Merged
Write directly to relevant notes file in changelog.py#19303huonw merged 10 commits intopantsbuild:mainfrom
huonw merged 10 commits intopantsbuild:mainfrom
Conversation
benjyw
approved these changes
Jun 14, 2023
Contributor
benjyw
left a comment
There was a problem hiding this comment.
Yay! I am currently working on code to generate the announcement message, including the list of contributors. So I will use your git() function once you merge.
Contributor
Author
|
Nice! I'll not touch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates
changelog.pyto write the (non-internal) changes to the relevant release notes file directly, rather than requiring a human to copy-paste it in. For now, the file is just mutated, without committing. The internal changes are still printed for the human to deal with.For instance,
pants run src/python/pants_release/changelog.py -- --prior 2.18.0.dev1 --new 2.18.0.dev2adds a new section tosrc/python/pants/notes/2.18.x.md:This also moves it into the new
pants_releaseroot, adds some basic tests, and has it fetch the relevant branch directly, rather than prompting the user to do so. It also pulls out agit.pysupport module with helpers for exec-inggitas an external process.The commits are individually reviewable.
This is a step towards automating more of the "start release" process, per #19279. After this core refactoring of the functionality, I think the next step is to combine it with the CONTRIBUTORS update and version bumping, and then after that string it all together on CI so that starting a release is fully automated.