[internal] Start of JS backend for target types and tailor goal#15442
Merged
Eric-Arellano merged 5 commits intopantsbuild:mainfrom May 13, 2022
Merged
[internal] Start of JS backend for target types and tailor goal#15442Eric-Arellano merged 5 commits intopantsbuild:mainfrom
Eric-Arellano merged 5 commits intopantsbuild:mainfrom
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Member
Author
|
This base support was honestly a copy/paste/find/replace of @tdyas I left |
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
May 13, 2022
Contributor
|
Ready for me to merge once CI goes green? |
Member
Author
|
Yep! |
Member
Author
|
Associated GH ticket stays open though, still have 2-3 more PRs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides step forward for a Javascript backend. It implements the target types
js_sourceandjs_sources, as well as tailor support. Creating Javascript test targets is deferred to a later PR.Typescript support is intentionally excluded at this time.
(See #14190)
[ci skip-rust]
[ci skip-build-wheels]