Fix some issues from #10535 Address changes#10555
Merged
Eric-Arellano merged 2 commits intopantsbuild:masterfrom Aug 5, 2020
Merged
Fix some issues from #10535 Address changes#10555Eric-Arellano merged 2 commits intopantsbuild:masterfrom
Eric-Arellano merged 2 commits intopantsbuild:masterfrom
Conversation
[ci skip-rust] [ci skip-build-wheels]
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The old validation for
BUILDin the spec path would incorrectly error for a generated subtarget withBUILDas its file. We only want to error ifBUILDis in thespec_path, but it's okay if it's in therelative_file_pathortarget_name.Our
speclogic was also incorrect for generated subtargets which live in a directory below the original target, where the original target is the default name.[ci skip-rust]
[ci skip-build-wheels]