ArgSplitter operates relative to the buildroot.#10540
Merged
Eric-Arellano merged 2 commits intopantsbuild:masterfrom Aug 3, 2020
Merged
ArgSplitter operates relative to the buildroot.#10540Eric-Arellano merged 2 commits intopantsbuild:masterfrom
Eric-Arellano merged 2 commits intopantsbuild:masterfrom
Conversation
# Rust tests and lints will be skipped. Delete if not intended. [ci skip-rust] # Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
Eric-Arellano
approved these changes
Aug 3, 2020
Comment on lines
-72
to
-76
| def assert_spec(arg: str) -> None: | ||
| assert ArgSplitter.likely_a_spec(arg) is True | ||
|
|
||
| def assert_not_spec(arg: str) -> None: | ||
| assert ArgSplitter.likely_a_spec(arg) is False |
Contributor
There was a problem hiding this comment.
Thanks for removing these. I agree it's more readable without these.
# Building wheels and fs_util will be skipped. Delete if not intended. [ci skip-build-wheels]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
#10535 normalizes specs to not include the trailing name when it will default. In order to fix tests, many instances of
src/example/test:testin output (the form is still supported and normalized in input) will be converted tosrc/example/test. To avoid needing to differentiate input from output though, and allow for a cleaner find-replace, I'm going to change all instances.While doing so, I noticed that the
ArgSplitteroperates relative to the current directory rather than the buildroot, which meant thatGoalRuleTestBasewas not recognizing file args or defaulted directory specs correctly.Solution
Adjust
ArgSplitterto operate relative to the buildroot.[ci skip-rust]
[ci skip-build-wheels]