Conversation
24472e1 to
863bbb5
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the LAVA hypercall struct to a shared header file and adds PANDA header files to the container/debian package, making it easier for developers to write C++ code with PANDA.
- Extracts
PandaHypercallStructand related definitions fromtaint2_hypercalls.hto a new shared headerpanda/include/panda/lava_hypercall_struct.h - Updates build and packaging configurations to install header files from
panda/include/during installation - Updates plugin includes to reference the new centralized header location
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| panda/include/panda/lava_hypercall_struct.h | New shared header file containing LAVA hypercall struct definitions, enabling synchronization between PANDA and LAVA |
| panda/plugins/taint2/taint2_hypercalls.h | Removes struct definition (now in shared header) and adds documentation comment pointing to new location |
| panda/plugins/taint2/taint2_hypercalls.cpp | Adds include for new shared header file |
| panda/plugins/pri_taint/pri_taint.cpp | Updates include path from plugin-specific to shared header location |
| Makefile | Adds installation step to recursively copy header files from panda/include/ to installation prefix |
| Dockerfile | Adds header files to debian package by copying from build stage to package-root |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
c6056de to
25272e9
Compare
25272e9 to
e31edd0
Compare
lacraig2
previously requested changes
Jan 15, 2026
Member
|
👍 Rebase and I'll merge. |
e31edd0 to
6a6fddf
Compare
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your checklist for this pull request
Detailed description
When installing PANDA, I also want to make sure the header files are included. This should make it easier for anyone who wants to write stuff in C++ with PANDA.
Additionally, regarding LAVA, I plan to relocate the hypercall struct to include it/ so PANDA can ensure that the struct is synchronized between LAVA and PANDA.
...
Test plan
Here is a screenshot confirming the Debian package now has the header files:
...
Closing issues
N/A
...