Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes LAVA bug injection issues caused by complex AST node names containing "**". The fix moves the filtering logic to the appropriate function and improves logging consistency. Additionally, the Debian setup script is enhanced to support versioning and proxy configurations.
Key Changes
- Moved AST node name filtering from
pfun()tolava_taint_query()to filter onastnodenameparameter instead ofvar_nm - Added
[pri_taint]prefix to debug output for better log consistency - Enhanced setup.sh with version validation, proxy support, and streamlined Docker build process
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| panda/plugins/pri_taint/pri_taint.cpp | Relocates "**" pattern check to lava_taint_query(), adds logging prefixes, and minor code style improvements (variable declaration scope) |
| panda/debian/setup.sh | Adds tag version parameter handling, implements version format validation, adds proxy environment variable support, and updates Docker build workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the bug injection step, the AST node name, *(((**(((*f)._chain)))._chain)) has been causing issues with bug injections.
LAVA is using AST node names to inject the bugs, but at least for toy, this value isn't needed. Whenever LAVA bug injection logic is re-written this can be removed I bet.