Use more precise type for formparser.MultiPartParser.parse return#2841
Merged
pgjones merged 1 commit intopallets:3.0.xfrom Mar 3, 2024
adamtheturtle:multipart-parser-strict-type
Merged
Use more precise type for formparser.MultiPartParser.parse return#2841pgjones merged 1 commit intopallets:3.0.xfrom adamtheturtle:multipart-parser-strict-type
pgjones merged 1 commit intopallets:3.0.xfrom
adamtheturtle:multipart-parser-strict-type
Conversation
Without this change, `pyright` with `typeCheckingMode` set to `strict` reports:
```
error: Type of "fields" is partially unknown
Type of "fields" is "MultiDict[Unknown, Unknown]" (reportUnknownVariableType)
```
when I use this method.
pgjones
approved these changes
Feb 29, 2024
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this change,
pyrightwithtypeCheckingModeset tostrictreports:when I use this method.
pyrightin strict mode errors when usingformparser.MultiPartParser.parse#2840Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.