Fix missing __getattr__ in FileStorage's interface#2199
Merged
davidism merged 1 commit intopallets:2.0.xfrom Aug 6, 2021
Merged
Fix missing __getattr__ in FileStorage's interface#2199davidism merged 1 commit intopallets:2.0.xfrom
davidism merged 1 commit intopallets:2.0.xfrom
Conversation
Contributor
Author
|
@davidism here it is. I've never really worked with .pyi interfaces before but hopefully it's ok 🙏 |
Member
|
Looks like your git email is misconfigured, it doesn't match the one that GitHub knows about. Do you want to fix that? |
2e0e456 to
3692b44
Compare
Contributor
Author
thanks for the heads up. Fixed |
f097c3b to
b156d60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing getattr in FileStorage's interface so that
mypyno longer wrongly complains thatFileStoragehas no attribute calledreadfixes #2155
Checklist:
CHANGES.rstsummarizing the change and linking to the issue.