Include host matching if possible when building URLs from mapped routes.#1673
Merged
davidism merged 2 commits intopallets:masterfrom Jan 5, 2020
aenglander:bugfix/488-host-matching-with-multiple-hosts-and-same-endpoint
Merged
Include host matching if possible when building URLs from mapped routes.#1673davidism merged 2 commits intopallets:masterfrom aenglander:bugfix/488-host-matching-with-multiple-hosts-and-same-endpoint
davidism merged 2 commits intopallets:masterfrom
aenglander:bugfix/488-host-matching-with-multiple-hosts-and-same-endpoint
Conversation
davidism
approved these changes
Jan 4, 2020
Member
|
Before I merge this, I want to make sure this doesn't cause all rules to be checked when host matching isn't enabled. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #488