SharedDataMiddleware returns 404 for package directory access#1647
Merged
SharedDataMiddleware returns 404 for package directory access#1647
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1599
The main fix is to catch
IOErrorwhen reading the data. The majority of the code change is removing the dependency on setuptools andpkg_resourcesin favor of the built-inpkgutils.I tried moving to
importlib_resourcesfor Python < 3.7, but for some reason that API doesn't support directories of resources unless the directory is also a package. I'm not sure why this restriction is there, give thatResourceReader.open_resourcesupports directories (althoughis_resourcedoesn't). Instead, we need two versions, using theloader.get_resource_reader()API on Python 3, and the package path andloader.get_data()method on Python 2.