Skip to content

Enable x_host and x_proto by default through deprecated proxyfix? #1630

@xmo-odoo

Description

@xmo-odoo

When #1314 refactored ProxyFix, it aliased num_proxies to x_for only (as that was the only one which previously supported multiple proxies).

However in doing so it disabled forwarding of host and scheme, which were forwarded by default up to 0.14, which breaks systems relying on this.

I'd like to set x_host=1 and x_proto=1 in 0.15 IFF the user goes through the deprecated wrapper (werkzeug.contrib.fixers.ProxyFix) in order to restore the old behaviour, and maybe add a small warning about this behavioural change to the deprecation message (or possibly in one of the versionchanged blocks of the new version). Would that be acceptable / interesting or a waste of time?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions