Add a DerivedContextReference node type#861
Merged
davidism merged 1 commit intopallets:masterfrom Dec 2, 2019
Merged
Conversation
Author
|
Oh, just noticed that I should be using fields, not attributes on the ContextReference node. |
Author
|
Hey folks, this is blocking me from doing some Jinja extension work elsewhere, and is a fairly self-contained change. Is there anything I can do to help get some eyeballs on it? |
38827bd to
8b6f6d2
Compare
Author
|
I've rebased this on to master, so now I have a passing Travis build. |
Member
|
Thanks, I'm not sure when I can get to this, but letting you know I've seen it. |
Author
|
Thanks for letting me know! |
Member
|
I feel like this might get deprecated if we fix various other open issues about context. But that's a much bigger task, and this seems fine until then. |
8b6f6d2 to
b75c6ea
Compare
This allows extensions to access locals in the scope from which they were called.
b75c6ea to
1539dd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows extensions to access locals in the scope from which they were called. Fixes #860