Add stricter checking to "from ... import ..."#618
Merged
davidism merged 2 commits intopallets:masterfrom Jul 7, 2017
jackwilsdon:stricter-from-parsing
Merged
Add stricter checking to "from ... import ..."#618davidism merged 2 commits intopallets:masterfrom jackwilsdon:stricter-from-parsing
davidism merged 2 commits intopallets:masterfrom
jackwilsdon:stricter-from-parsing
Conversation
davidism
requested changes
Nov 1, 2016
Member
davidism
left a comment
There was a problem hiding this comment.
Needs test. Otherwise, seems fine to me. Waiting for feedback from another maintainer.
Contributor
|
Basically needs tests. |
Member
|
@jackwilsdon are you still interested in your PR and willing to provide tests? |
Currently token parsing on "from ... import ..." is rather "loose" — it
sees the following "invalid" code as perfectly valid:
{% from "functions" import my_function, %}
{% from "functions" import, %}
{% from "functions" import %}
This is caused by the parser ignoring non-name values where there should
be names, either as the first value or after commas.
This commit ensures only name values are allowed as the first value and
any values after commas in the import section.
davidism
approved these changes
Jul 7, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently token parsing on "from ... import ..." is rather loose — it sees the following invalid code as perfectly valid:
This is caused by the parser ignoring non-name values where there should be names, either as the first value or after commas.
This PR ensures only name values are allowed as the first value and any values after commas in the import section.
Sadly this may be a "semi-breaking" change, as it removes some functionality that should have never existed and hopefully nobody relies on.