Prevent random filter from being inlined#478
Closed
snoack wants to merge 1 commit intopallets:masterfrom
snoack:dont-inline-random
Closed
Prevent random filter from being inlined#478snoack wants to merge 1 commit intopallets:masterfrom snoack:dont-inline-random
snoack wants to merge 1 commit intopallets:masterfrom
snoack:dont-inline-random
Conversation
|
I've encountered this bug with Jinja 2.9.6 and this patch fixes it. If this isn't merged, a workaround is to simply override |
Member
|
New test doesn't fail when run on master. |
Member
|
Continued in #734. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, due to #476 environment filters like
randomaren't optimized/inlined. While this is a bug for any other filter, therandomfilter should never be inlined, but always be evaluated at runtime. Otherwise, once the template is compiled, therandomfilter would always give the same results. So this pull request turnsrandominto acontextfilterto prevent it from being inlined.