Skip to content

sandbox disallows clear and pop on mutable sequence#2033

Merged
davidism merged 1 commit intopallets:stablefrom
dylanscott:main
Dec 19, 2024
Merged

sandbox disallows clear and pop on mutable sequence#2033
davidism merged 1 commit intopallets:stablefrom
dylanscott:main

Conversation

@dylanscott
Copy link
Copy Markdown
Contributor

This PR adds the attributes clear and pop on MutableSequence to the default modifies_known_mutable check used by ImmutableSandboxedEnvironment.

fixes #2032

Let me know if I should add an entry to CHANGES.rst. I didn't see any previous mention of ImmutableSandboxedEnvironment in there so I wasn't sure if I should.

@davidism davidism added this to the 3.1.5 milestone Dec 18, 2024
@davidism davidism changed the base branch from main to stable December 19, 2024 16:32
@davidism davidism changed the title add MutableSequence.{clear,pop} to modifies_known_mutable check sandbox disallows clear and pop on mutable sequence Dec 19, 2024
@davidism davidism merged commit 91e3521 into pallets:stable Dec 19, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MutableSequence coverage in ImmutableSandboxedEnvironment

2 participants