Skip to content

Make nested-trans-block exceptions nicer#1918

Merged
davidism merged 1 commit intopallets:3.1.xfrom
akx:nicer-nested-trans-error
Jan 10, 2024
Merged

Make nested-trans-block exceptions nicer#1918
davidism merged 1 commit intopallets:3.1.xfrom
akx:nicer-nested-trans-error

Conversation

@akx
Copy link
Copy Markdown
Contributor

@akx akx commented Dec 15, 2023

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
    • Not relevant IMO.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
    • Not relevant IMO.
  • Run pre-commit hooks and fix any issues.
    • There is an unrelated flake8 failure.
  • Run pytest and tox, no tests failed.

@davidism
Copy link
Copy Markdown
Member

Nice idea, thanks for making this error message clearer! I'm not sure when this will get merged in, but it's on the list.

@davidism davidism added this to the 3.1.3 milestone Dec 15, 2023
@davidism davidism changed the base branch from main to 3.1.x January 10, 2024 22:25
@davidism davidism force-pushed the nicer-nested-trans-error branch from 379f093 to 19a55db Compare January 10, 2024 22:27
@davidism davidism merged commit 5c8a105 into pallets:3.1.x Jan 10, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Jan 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants