Fix Race conditions in FileSystemBytecodeCache#1655
Merged
davidism merged 1 commit intopallets:3.1.xfrom Apr 25, 2022
Merged
Conversation
dvitek
commented
Apr 10, 2022
ThiefMaster
reviewed
Apr 10, 2022
77111f3 to
080260f
Compare
Member
|
I'm going to remove the tests because in the past having tests that relied on race conditions was very flaky and caused confusion for contributors when unrelated PRs failed. |
Contributor
Author
|
ok |
Contributor
Author
|
FWIW, the test tests for the absence of a race, if that makes a difference. It should not fail intermittently, unless the bug is re-introduced. |
Member
|
The problem with that is that there no guarantee that a race happened and was handled vs normal behavior happened. And any such check would then rely on producing the race, which is flaky. |
8fc431f to
0e3a243
Compare
0e3a243 to
746bb95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix race conditions in FileSystemBytecodeCache. See #1654 for a detailed description of the race conditions.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.