native: keep same behavior on Python 3.10#1537
Merged
davidism merged 1 commit intopallets:3.0.xfrom Nov 9, 2021
Merged
Conversation
Member
|
Seems appropriate for a bugfix release, can you rebase this to 3.0.x? |
2cd8c83 to
0e05fd6
Compare
Contributor
Author
Done. |
0e05fd6 to
bb0db82
Compare
Member
|
@mkrizek I'm planning to drop support for Python 3.9, so 3.10 will be the minimum version. I can't remember the context for this fix. Now that 3.10 is the minimum, should we revert this, or continue to avoid |
Contributor
Author
|
@davidism I believe reverting this change would break existing templates so we should leave this as is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.