Reduce async overhead due to auto_await#1516
Merged
davidism merged 1 commit intopallets:3.0.xfrom Nov 9, 2021
mohd-akram:async-perf
Merged
Reduce async overhead due to auto_await#1516davidism merged 1 commit intopallets:3.0.xfrom mohd-akram:async-perf
davidism merged 1 commit intopallets:3.0.xfrom
mohd-akram:async-perf
Conversation
Contributor
Author
|
@davidism Have you had a chance to look at this? |
Member
|
No not yet. When I do, I'll leave a review, comment, or merge and you'll get a notification. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The types of most rendered values tend to be primitives, so we can avoid a costly call to
inspect.isawaitablefor them. This improves performance by at least 15% in my tests.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.