Skip to content

Only StrictUndefined.__contains__ raises error#1455

Merged
davidism merged 1 commit intopallets:3.0.xfrom
ewjoachim:undefined-contains-1204
Aug 9, 2021
Merged

Only StrictUndefined.__contains__ raises error#1455
davidism merged 1 commit intopallets:3.0.xfrom
ewjoachim:undefined-contains-1204

Conversation

@ewjoachim
Copy link
Copy Markdown
Contributor

@ewjoachim ewjoachim commented May 26, 2021

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
    • There was no docs added when this was set, so there shouldn't be doc to remove or change.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
    • No docstring changed
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@ewjoachim ewjoachim changed the title Fixes #1204: Revert Undefined.__contains__ to 2.x Fixes #1204: Revert Undefined.__contains__ to 2.x behaviour May 26, 2021
@ewjoachim ewjoachim force-pushed the undefined-contains-1204 branch 2 times, most recently from 15e4522 to 7115856 Compare May 26, 2021 10:11
@ewjoachim ewjoachim changed the title Fixes #1204: Revert Undefined.__contains__ to 2.x behaviour Fixes #1448: Revert Undefined.__contains__ to 2.x behaviour May 26, 2021
@davidism davidism changed the title Fixes #1448: Revert Undefined.__contains__ to 2.x behaviour Only StrictUndefined.__contains__ raises error May 26, 2021
@davidism davidism added this to the 3.0.2 milestone May 26, 2021
@davidism davidism force-pushed the undefined-contains-1204 branch from 7115856 to d5f49f5 Compare August 9, 2021 18:07
@davidism davidism changed the base branch from main to 3.0.x August 9, 2021 18:07
@davidism davidism merged commit 531145d into pallets:3.0.x Aug 9, 2021
@ewjoachim ewjoachim deleted the undefined-contains-1204 branch August 9, 2021 19:10
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Aug 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

containment should only fail for StrictUndefined, not regular Undefined

2 participants