Conversation
Member
Author
Member
|
As I understand it the imports are in I wonder though if these sync methods should instead raise runtime/not implemented errors in an async environment. I think this would happen naturally anyway as calling |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The patching is not required,
async defis valid in all supported Python versions. Moves the async/patched sync functions fromasyncsupportinto the regular code. Moves the async filters fromasyncfilterstofilters. This does mess with the signature arguments in the docs for the filters, I think that can be fixed in Pallets-Sphinx-Theme's Jinja support.import asynciois done insiderenderandgenerateto avoid importing it at the top, which would slow down import time.Checklist:
CHANGES.rstsummarizing the change and linking to the issue... versionchanged::entries in any relevant code docs.pre-commithooks and fix any issues.pytestandtox, no tests failed.