Add 'linetable' to the list of preserved CodeType attributes.#1334
Merged
davidism merged 2 commits intopallets:masterfrom Jan 19, 2021
Merged
Add 'linetable' to the list of preserved CodeType attributes.#1334davidism merged 2 commits intopallets:masterfrom
davidism merged 2 commits intopallets:masterfrom
Conversation
As part of python/cpython#23113 partly implementing PEP 626 (see https://bugs.python.org/issue42246), the co_lnotab member of struct PyCodeObject was replaced by co_linetable, implementing a new line number table. This commit therefore adds linetable to the list of attributes that are copied over into the final CodeType executed by fake_traceback() to ensure proper line numbers and contents in fake stack traces generated when running under Python 3.10. Fixes pallets#1333.
for more information, see https://pre-commit.ci
Member
|
Not sure why I merged this at the time, but this didn't actually fix things. First, the The fact that everything passed was due to the See #1535 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As part of python/cpython#23113 partly
implementing PEP 626 (see https://bugs.python.org/issue42246), the
co_lnotab member of struct PyCodeObject was replaced by co_linetable,
implementing a new line number table.
This commit therefore adds linetable to the list of attributes that
are copied over into the final CodeType executed by fake_traceback()
to ensure proper line numbers and contents in fake stack traces
generated when running under Python 3.10.
Fixes #1333.