Skip to content

Fix custom async filters#1303

Merged
davidism merged 1 commit intopallets:masterfrom
gibson042:gh-1279-custom-async-filters
Nov 1, 2020
Merged

Fix custom async filters#1303
davidism merged 1 commit intopallets:masterfrom
gibson042:gh-1279-custom-async-filters

Conversation

@gibson042
Copy link
Copy Markdown
Contributor

@gibson042 gibson042 commented Oct 22, 2020

Detect custom async filters in as_const

Checklist:

  • Add tests that demonstrate the correct behavior of the change. Tests should fail without the change.
  • Add or update relevant docs, in the docs folder and in code.
  • Add an entry in CHANGES.rst summarizing the change and linking to the issue.
  • Add .. versionchanged:: entries in any relevant code docs.
  • Run pre-commit hooks and fix any issues.
  • Run pytest and tox, no tests failed.

@davidism davidism force-pushed the gh-1279-custom-async-filters branch from 8bddadd to e1d0131 Compare November 1, 2020 02:07
@davidism davidism added this to the 3.0.0 milestone Nov 1, 2020
@davidism davidism added the async label Nov 1, 2020
@davidism davidism merged commit 1eca37b into pallets:master Nov 1, 2020
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Custom async filters not awaited for constant inputs

2 participants