Fix bugs with contextfunction and loop variables#1242
Merged
amy-lei merged 2 commits intopallets:masterfrom Mar 26, 2021
Merged
Fix bugs with contextfunction and loop variables#1242amy-lei merged 2 commits intopallets:masterfrom
amy-lei merged 2 commits intopallets:masterfrom
Conversation
Contributor
Author
|
Had a discussion with @davidism. Having both a However, at the moment, there doesn't seem to be other block tags with this context access issue. So when one does come up, we can refactor/address this then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #768 and #1088 (closed as dupe but turned out to be slightly different)
Summary:
loopand its special variablescontextfunctioncan access variables set inside of loops and blocksFrame, tracking assignments made in loops or blocks, and passing it asextra_kwargsFiles Changed:
compiler.pyruntime.pytest_regression.py