Fix bug with imported macros and template globals#1241
Merged
davidism merged 2 commits intopallets:masterfrom Jun 22, 2020
Merged
Fix bug with imported macros and template globals#1241davidism merged 2 commits intopallets:masterfrom
davidism merged 2 commits intopallets:masterfrom
Conversation
davidism
reviewed
Jun 22, 2020
davidism
reviewed
Jun 22, 2020
Member
|
|
9276aa7 to
acf193b
Compare
_get_default_module takes an optional context to indicate that the template is imported. If there are differences between the environment and rendered template globals, a new module is used for the imported template.
acf193b to
cc792d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #688
_get_default_moduleto take in the current context and make a new module if template globals are foundself.globalsto the Context class to differentiate between template variables from render variables.