Skip to content

Allow namespaces to be used in asynchronously rendered templates.#1181

Merged
davidism merged 1 commit intopallets:2.11.xfrom
bartfeenstra:async-namespace
Mar 30, 2020
Merged

Allow namespaces to be used in asynchronously rendered templates.#1181
davidism merged 1 commit intopallets:2.11.xfrom
bartfeenstra:async-namespace

Conversation

@bartfeenstra
Copy link
Copy Markdown
Contributor

@bartfeenstra bartfeenstra commented Mar 28, 2020

This fixes #1180, by allowing Namespace instances to undergo the type checks necessary for async compatibility.

@davidism davidism requested a review from ThiefMaster March 28, 2020 18:22
ThiefMaster
ThiefMaster reviewed Mar 28, 2020
View reviewed changes
Comment thread tests/test_utils.py Outdated
ThiefMaster
ThiefMaster approved these changes Mar 29, 2020
View reviewed changes
Comment thread tests/test_utils.py Outdated
@davidism davidism changed the base branch from master to 2.11.x March 30, 2020 18:28
@davidism davidism added this to the 2.11.2 milestone Mar 30, 2020
@davidism davidism merged commit 786867a into pallets:2.11.x Mar 30, 2020
@bartfeenstra bartfeenstra deleted the async-namespace branch March 31, 2020 20:55
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@ThiefMaster ThiefMaster ThiefMaster approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.11.2

Development

Successfully merging this pull request may close these issues.

Using namespaces asynchronously raises fatal AttributeError

3 participants

@bartfeenstra @ThiefMaster @davidism