Add support for hex, octal, and binary integer literals#1171
Merged
davidism merged 1 commit intopallets:masterfrom Apr 5, 2021
amykyta3:feature/base-integer-literals
Merged
Add support for hex, octal, and binary integer literals#1171davidism merged 1 commit intopallets:masterfrom amykyta3:feature/base-integer-literals
davidism merged 1 commit intopallets:masterfrom
amykyta3:feature/base-integer-literals
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1170
Since Jinja expression syntax closely mimics Python, it is surprising that not all of Python's integer literal representations are supported:
https://docs.python.org/3/reference/lexical_analysis.html#integer-literals
This pull request extends the lexer to be able to understand all of the integer literal formats that Python supports.
Unit-tests have been extended as appropriate.