Use stricter getattr() checks for decorator functions#1146
Merged
davidism merged 2 commits intopallets:2.11.xfrom Feb 4, 2020
Merged
Use stricter getattr() checks for decorator functions#1146davidism merged 2 commits intopallets:2.11.xfrom
davidism merged 2 commits intopallets:2.11.xfrom
Conversation
Explicit checks for "is True" prevents unexpected behaviour with objects that are callable and have permissive gettatr(), such as Mock. Fixes pallets#1145
25bbfe3 to
9933324
Compare
0673710 to
0429499
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit checks for "is True" prevents unexpected behaviour with objects
that are callable and have permissive gettatr(), such as Mock.
Fixes #1145