Use 'callable' instead of typechecking for runtime calls ctx/env injection#1108
Merged
davidism merged 1 commit intopallets:masterfrom Nov 20, 2019
Merged
Use 'callable' instead of typechecking for runtime calls ctx/env injection#1108davidism merged 1 commit intopallets:masterfrom
davidism merged 1 commit intopallets:masterfrom
Conversation
31ec1bd to
70ea1d3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When jinja2 is used from Cython-compiled code, Functions and Methods are not
types.FunctionTypeortypes.MethodTypeanymore. Instead they arecython_function_or_method. The framework does not recognize decorated functions/methods and doesn't inject the needed parameters before the call execution.Using
callableis backward compatible with existing implementation and also compatible with Cython-compiled code.